Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAlex Integration #4017

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

AdamF42
Copy link

@AdamF42 AdamF42 commented Feb 20, 2025

Please note that this development has been funded by the Vietsch foundation, co-funded by 4Science and the project coordination is provided by University of Cambridge.


References

Description

Reference the description in DSpace/DSpace#10433

Instructions for Reviewers

Reference the instruction in DSpace/DSpace#10433

List of changes in this PR:

  • Fixed problem with suggestion import.
  • Added labels for newly created openalex live importer.
    Try to import a suggestion, a submission should be created with import related field filled.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added new feature 1 APPROVAL pull request only requires a single approval to merge labels Feb 20, 2025
@AdamF42 AdamF42 mentioned this pull request Feb 20, 2025
10 tasks
@AdamF42 AdamF42 force-pushed the task/main/CST-18016 branch 2 times, most recently from be7901d to 263813e Compare February 20, 2025 18:12
@AdamF42 AdamF42 force-pushed the task/main/CST-18016 branch from 263813e to caa5b1e Compare February 20, 2025 18:51
@AdamF42 AdamF42 marked this pull request as ready for review February 21, 2025 13:18
@AdamF42 AdamF42 changed the title [CST-18016] Fix import suggestion Fix import suggestion Feb 21, 2025
@AdamF42 AdamF42 changed the title Fix import suggestion OpenAlex Integration Feb 21, 2025
@tdonohue tdonohue self-requested a review February 27, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge new feature
Projects
Status: 👀 Under Review
Development

Successfully merging this pull request may close these issues.

2 participants